Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .NET SDK Container Build #3960

Merged
merged 47 commits into from
Jun 15, 2023
Merged

Support .NET SDK Container Build #3960

merged 47 commits into from
Jun 15, 2023

Conversation

alexyaang
Copy link
Member

@alexyaang alexyaang commented Jun 6, 2023 •
edited
Loading

This PR closes #3808

Tests

  • Debug a .NET project with .NET SDK Container
  • Debug a .NET project with Dockerfile (check for regression)
  • Debug a python project with Dockerfile (check for regression)

More tests

  • .NET SDK
  • .NET normal build
  • python
  • node
  • scaffolded task and then run it

alexyaang added 30 commits May 11, 2023 17:55
@alexyaang
Experimental Base Structure
3b319b0
@alexyaang
register new task provider
794d867
@alexyaang
added build options for DotnetSdk
127f053
@alexyaang
removed redundent fields in NetCoreSdkBuildOptions
09236a7
@alexyaang
added json schema
dbfc62a
@alexyaang
basci working implementation of task provider
b9b9607
@alexyaang
reversed unnecessary commits
d289b42
@alexyaang
added dotnet specific util methods
6982df7
@alexyaang
fixed dotnet CLI flags
4cd942e
@alexyaang
made code more organized
26058d3
@alexyaang
organiized files into new folder
9a148bc
@alexyaang
added helper class
440cb49
@alexyaang
combined build & run into one task
ee21b06
@alexyaang
adddded working version of run command
7d62777
@alexyaang
added mounts to run arg
78f1374
@alexyaang
added ambient launch task
9832b7b
@alexyaang
working version of ambient launch task
b2712c8
@alexyaang
added prompt for docker debugger on csharp languag
86cc95f
@alexyaang
stored user image build choices
796c1ad
@alexyaang
added auto .csproj selection & refactored code
068fcc1
@alexyaang
added debug helper
a054ac9
@alexyaang
small tweaks to handle null cases
b113ce7
@alexyaang
add appOutput override to fix dotnet project name bug
edf1338
@alexyaang
fixed image not running if foldername has special chars
8920a8f
@alexyaang
changed task name and altered schema
def78b9
@alexyaang
determine helper from prelaunchtask instead of platform
8b5fedd
@alexyaang
move helper methods to taskhelper
132f252
@alexyaang
cleaned up unused comments & method
bcb9d9d
@alexyaang
made NetTaskHelper more readable
46df754
@alexyaang
changed momento name to more detailed
0afe708
@microsoft microsoft deleted a comment from Gostqa Jun 9, 2023
@alexyaang alexyaang mentioned this pull request Jun 14, 2023
Open
bwateratmsft
bwateratmsft previously approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @danegsta can you also take a final look?

@alexyaang alexyaang merged commit f6b6483 into main Jun 15, 2023
@alexyaang alexyaang deleted the yangalex/ambientSdkTask branch June 15, 2023 19:53
@bwateratmsft bwateratmsft mentioned this pull request Jun 19, 2023
Merged
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baronfel baronfel baronfel left review comments

@bwateratmsft bwateratmsft bwateratmsft approved these changes

@danegsta danegsta danegsta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable debugging support for .NET native container builds
4 participants
@alexyaang @baronfel @bwateratmsft @danegsta